-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin(jfrog-artifactory): initial migration of jfrog-artifactory plu… #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BethGriggs
requested review from
backstage-service and
a team
as code owners
September 26, 2024 12:19
BethGriggs
force-pushed
the
migrate-jfrog
branch
from
September 26, 2024 12:20
545fdb0
to
fe0e3ea
Compare
Changed Packages
|
just a reminder to add the new codeowner 😄 |
BethGriggs
force-pushed
the
migrate-jfrog
branch
from
October 2, 2024 15:57
bcfb054
to
1225292
Compare
04kash
reviewed
Oct 2, 2024
workspaces/jfrog-artifactory/plugins/jfrog-artifactory/app-config.janus-idp.yaml
Outdated
Show resolved
Hide resolved
vinzscam
force-pushed
the
migrate-jfrog
branch
from
October 7, 2024 15:17
1225292
to
99b315d
Compare
Is it worth having a sample app for developing/testing the plugin? We can do it in another PR if it's worthwhile and easier |
vinzscam
approved these changes
Oct 7, 2024
vinzscam
force-pushed
the
migrate-jfrog
branch
from
October 7, 2024 15:23
99b315d
to
0e0e467
Compare
@vinzscam - I will plan for that in a follow-up PR |
…gin from janus-idp/backstage-plugins The [jfrog-artifactory](https://github.com/janus-idp/backstage-plugins/tree/main/plugins/jfrog-artifactory) plugin from the [janus-idp/backstage-plugins](https://github.com/janus-idp/backstage-plugins) repository was migrated to the [community plugins](https://github.com/backstage/community-plugins/tree/main), based on commit 0c7c7f4a. The migration was performed by following the manual migration steps outlined in the [Community Plugins CONTRIBUTING guide](https://github.com/backstage/community-plugins/blob/main/CONTRIBUTING.md#migrating-a-plugin). Signed-off-by: Beth Griggs <[email protected]>
Signed-off-by: Beth Griggs <[email protected]>
Signed-off-by: Beth Griggs <[email protected]>
Signed-off-by: Beth Griggs <[email protected]>
BethGriggs
force-pushed
the
migrate-jfrog
branch
from
October 8, 2024 14:38
67f1064
to
c512f09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…gin from janus-idp/backstage-plugins
The jfrog-artifactory plugin from the janus-idp/backstage-plugins repository was migrated to the community plugins, based on commit 0c7c7f4a. The migration was performed by following the manual migration steps outlined in the Community Plugins CONTRIBUTING guide.
Hey, I just made a Pull Request!
✔️ Checklist
Signed-off-by
line in the message. (more info)