Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feedback): add support to integrate to backstage notifications #1463

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

drodil
Copy link
Contributor

@drodil drodil commented Oct 2, 2024

Hey, I just made a Pull Request!

This adds support to send notification to the entity (as in, its owner) when a new feedback is given. Requires that notifications service is installed in the application and enabled in the feedback configuration.

Closes #1460

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@drodil drodil requested review from yashoswalyo and a team as code owners October 2, 2024 11:04
@drodil drodil requested a review from nickboldt October 2, 2024 11:04
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-feedback-backend workspaces/feedback/plugins/feedback-backend patch v1.7.4

Copy link
Member

@yashoswalyo yashoswalyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yashoswalyo
Copy link
Member

@drodil can you update api-reports.md too, pipeline is failing because of that
or run yarn build:api-reports in workspaces/feedback/ folder and commit api-report file too

@yashoswalyo yashoswalyo enabled auto-merge (squash) October 3, 2024 07:19
This adds support to send notification to the entity (as in, its owner)
when a new feedback is given. Requires that notifications service is
installed in the application and enabled in the feedback configuration.

Closes backstage#1460

Signed-off-by: Heikki Hellgren <[email protected]>
@yashoswalyo yashoswalyo merged commit 639cb05 into backstage:main Oct 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feedback: Integrate notifications
2 participants