[BREAKING] Consolidate all create, edit, and delete functionality into the unified AdminPortal #6273
+113
−1,665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backstage-service
added
the
workspace/announcements
Contributor
Changed Packages
|
kurtaking
force-pushed
the
deprecate-individual-manage-pages
branch
from
20ceb07 to
9085945
Compare
5 tasks
Removes all individual pages for creating and edits announcements, categories, and tags. Users must use the admin portal component in order to manage announcements, categories, and tags. Signed-off-by: Kurt King <[email protected]>
kurtaking
force-pushed
the
deprecate-individual-manage-pages
branch
from
9085945 to
7492b3a
Compare
Signed-off-by: Kurt King <[email protected]>
Contributor
|
Thanks for the contribution! |
This reverts commit 7b557c2. Signed-off-by: Kurt King <[email protected]>
Signed-off-by: Kurt King <[email protected]>
kurtaking
force-pushed
the
deprecate-individual-manage-pages
branch
from
dfe8593 to
9186480
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
We are consolidating all functionality into the admin portal. The previous version provides individual pages for each of these entry points which have now been removed.
As the plugin's adoption grew, more requests to hide UI components based on permissions came in. This decision was made to simplify the plugin and reduce the complexity of the codebase. It also provides a more consistent UX for admin operations and allows for more flexibility in the future.
Breaking Changes
Removed Routes
The following route references have been removed and are no longer available:
announcementCreateRouteRef- UseannouncementAdminRouteRefinsteadannouncementEditRouteRef- UseannouncementAdminRouteRefinsteadcategoriesListRouteRef- Categories are now managed within the Admin PortaltagsListRouteRef- Tags are now managed within the Admin PortalRemoved Components
The following components have been removed:
CreateAnnouncementPage- Replaced byAdminPortalwith Announcements tabEditAnnouncementPage- Replaced byAdminPortalwith Announcements tabCategoriesPage- Replaced byAdminPortalwith Categories tabTagsPage- Replaced byAdminPortalwith Tags tabNewCategoryDialog- Category creation is now handled inline within the Categories tabNewTagDialog- Tag creation is now handled inline within the Tags tabComponent Reorganization
Admin-related components have been reorganized into feature-specific directories:
Admin/AnnouncementsContent/- Contains announcement management componentsAdmin/CategoriesContent/- Contains category management componentsAdmin/TagsContent/- Contains tag management componentsBenefits
/announcements/admin)@backstage/uiand the new frontend systemHighlights
AnnouncementsCardcomponent now links to the admin portal instead of the create page.✔️ Checklist
Signed-off-byline in the message. (more info)