-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: global version category prefix query param [amo archlinux aur bower cdnjs chromewebstore cocoapods conan conda cookbook cpan cran crates ctan curseforge debian dockerVersion dub eclipsemarketplace elmpackage f-droid factorio fedora feedz flathub galaxytoolshed gem gitea] #10685
Conversation
|
I think I am against adding this as a user configuration option but I won't block it if other maintainers agree with adding it. |
Thanks for taking a stab at this! I'm also lukewarm about adding a new user-facing configuration option. It adds a tiny bit of complexity both in our codebase and in the number of choices the user is faced with when creating a new badge. It would also mean that the information shown by two badges belonging to the same service may be formatted slightly differently based on the personal preference of whoever put the badge on their README; whilst not the end of the world, this would effectively degrade horizontal consistency. |
I read your feedback and gave this another thought. You're the old hand here. If something feels off about this change, I trust your gut. Thank you for taking the time about this. |
Altho i am aware of #6135 this is an attempt to make this manageable.
I dont mind if this ends up unused as i took this as an opportunity to play a bit with the codebase internals.
Let me know if you think this change is elegant and easy to maintain or more of an anchor might risks confusion in the codebase.
Introduce global category-specific query parameters and add versionPrefix support across version badges.