Add active path highlighting in html exports #929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hewliyang
changed the title
hewliyang
force-pushed
the
hly/fix/share-html-tree-nav-scroll
branch
from
d958f9a to
193b29b
Compare
hewliyang
changed the title
hewliyang
changed the title
hewliyang
added a commit
to hewliyang/pi-mono
that referenced
this pull request
Jan 25, 2026
- Remove unused childrenMap, findBranchLeaf, handleTreeNodeClick, scrollToEntry - Split changelog entry: navigation (badlogic#853 by @mitsuhiko), highlighting (badlogic#929 by @hewliyang)
hewliyang
changed the title
…ating branch Previously, clicking a message in the sidebar tree would set that message as the new leaf, causing getPath() to only return messages up to that point and hiding all messages below it. Now handleTreeNodeClick() checks if the clicked entry is on the current path: - If yes: just scrolls to it without re-rendering - If no: finds the actual leaf of that branch and navigates to it, then scrolls to the clicked message Added childrenMap for parent->children lookup and findBranchLeaf() to traverse down to a branch's leaf.
…ating branch Previously, clicking a message in the sidebar tree would set that message as the new leaf, causing getPath() to only return messages up to that point and hiding all messages below it. Now handleTreeNodeClick() checks if the clicked entry is on the current path: - If yes: scrolls to it and updates the active marker - If no: finds the branch's leaf, navigates to it, then scrolls to clicked message Adds currentTargetId to track the selected entry separately from currentLeafId (which branch to display), so the active marker follows user selection.
- Add subtle accent background tint to in-path nodes - Dim off-path nodes to 50% opacity (restore on hover) - Makes current branch visually distinct in tree navigation
hewliyang
force-pushed
the
hly/fix/share-html-tree-nav-scroll
branch
from
799ae00 to
89b249c
Compare
hewliyang
added a commit
to hewliyang/pi-mono
that referenced
this pull request
Jan 25, 2026
- Remove unused childrenMap, findBranchLeaf, handleTreeNodeClick, scrollToEntry - Split changelog entry: navigation (badlogic#853 by @mitsuhiko), highlighting (badlogic#929 by @hewliyang)
- Remove unused childrenMap, findBranchLeaf, handleTreeNodeClick, scrollToEntry - Split changelog entry: navigation (badlogic#853 by @mitsuhiko), highlighting (badlogic#929 by @hewliyang)
hewliyang
force-pushed
the
hly/fix/share-html-tree-nav-scroll
branch
from
89b249c to
4fdb168
Compare
Contributor
Author
|
Woops did not realize @mitsuhiko's #853 which implemented #572 💀 Cleaned up the dead code & removed the duplicate ### Fixes in the changelog. |
Owner
|
Beautiful, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added highlighting of the active path
&
Active item in the tree can now be the selected message instead of the leaf of the active path
Screen.Recording.2026-01-24.at.16.14.21.mov