-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MVICore RxJava3 update #198
base: master
Are you sure you want to change the base?
Conversation
mvicore/src/main/java/com/badoo/mvicore/consumer/playback/MemoryRecordStore.kt
Fixed
Show fixed
Hide fixed
) | ||
} | ||
} | ||
val event = cachedEvents[firstKey] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this always works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it is a good question. But it is true for the previous implementation too.
.let { key ->
Observable.fromIterable(cachedEvents[key])
...
}
RxJava2 version does not have @NonNull
annotation, so Kotlin compiler allows passing a nullable value here, while it will still throw an exception in runtime.
RxJava3 version now has @NonNull
annotation, so Kotlin compiler is more strict here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt it worked fine in the previous version as well. Because the result of the subscription is not used anywhere, hence there’s no manual unsubscribe implemented.
Description
...
Check list
CHANGELOG.md
if required.