fix: inputTree defer模式下悬浮不展示操作按钮 #10873#10883
Merged
hsm-lv merged 1 commit intobaidu:masterfrom Sep 18, 2024
Merged
Conversation
|
👍 Thanks for this! Please review the labels and make any necessary changes. |
Contributor
Author
|
这个pr有啥问题吗？我理解新增icon不应该加这个限制。如果配置了addApi，新增完会自动调deferApi并打开当前层级是没有问题的。 @2betop |
Member
|
可以删除，可以编辑，但是应该限制新增吧，都不知道有没有孩子，就新增总感觉不妥 |
Contributor
Author
我理解即使当前defer节点没有孩子，新增之后先调用appApi新增，然后调deferApi拉取，这时候应该就有孩子了。理论上没问题，除非addApi添加数据是异步的，新增之后deferApi不会及时获取。 |
Member
|
看不到孩子列表，我怎么决定要不要新增呢，万一加重复了？ |
thinkingc
force-pushed
the
fix-inputTree-defer
branch
from
5659967 to
8c5c37f
Compare
Contributor
Author
有点道理，我先在改成只限制新增按钮了。麻烦看下是否可行。 |
2betop
approved these changes
Sep 11, 2024
hsm-lv
approved these changes
Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
#10873
Why
How