New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gc something at destory "NameSlaveImpl" instance and format logs #803

Open

baobaoyeye wants to merge 3 commits into baidu:master from baobaoyeye:patch-1

Contributor

baobaoyeye commented Jan 15, 2017

int64_t 用 %d 打印不会报错，存在溢出风险
个人理解NameSlaveImpl缺少必要的析构，和对堆上分配资源的回收

baobaoyeye added 3 commits

January 11, 2017 20:33


          delete leveldb before exit function

f730914


          Merge branch 'master' of https://github.com/baidu/bfs into utils_branch

67fd311


          gc something at destory MasterSlaveImpl and logs format

07e8de1

Collaborator

bluebore commented Jan 27, 2017

感觉这个析构还是很必要的，@lylei 看下怎么能不冲突地merge了吧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment