Concurrent load disk when cs starts #880 #882
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvxiang
reviewed
Mar 28, 2017
| @@ -20,16 +20,20 @@ class DataBlockTest : public ::testing::Test { | |||
| protected: | |||
| }; | |||
|
|
|||
| void AddBlock(int64_t block_id, Disk* disk, BlockMeta meta) { | |||
| void AdBlock(int64_t block_id, Disk* disk, BlockMeta meta) { | |||
src/chunkserver/block_manager.cc
Outdated
| // return value from Disk::LoadStorage: | ||
| // 0: initial state, 1: done, -1: error occured | ||
| std::vector<int> ret_vals; | ||
| ret_vals.resize(disks_.size()); |
yvxiang
reviewed
Mar 28, 2017
src/chunkserver/block_manager.cc
Outdated
| @@ -165,15 +165,46 @@ int64_t BlockManager::DiskQuota() const { | |||
|
|
|||
| // TODO: concurrent load | |||
yvxiang
approved these changes
Mar 28, 2017
bluebore
approved these changes
Apr 9, 2017
| // return value from Disk::LoadStorage: | ||
| // 0: initial state, 1: done, -1: error occured | ||
| std::vector<int> ret_vals; | ||
| ret_vals.resize(disks_.size(), 0); |
There was a problem hiding this comment.
可以直接写成
std::vector ret_vals(disks_.size(), 0);
| std::placeholders::_3)); | ||
| disk_quota_ += disk->GetQuota(); | ||
| std::placeholders::_3); | ||
| tp.AddTask(std::bind(&Disk::LoadStorage, disk, callback, &(ret_vals[disk_index]))); |
There was a problem hiding this comment.
用不着这么多层括号吧, &ret_vals[disk_index]应该就是可以的
| } | ||
| bool ret = true; | ||
| while (true) { | ||
| sleep(1); |
There was a problem hiding this comment.
感觉没必要上来就sleep一秒, 说不定已经完成了呢
sleep可以放循环的最后
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(#880)