Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SMAP L3 soil moisture #19

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add SMAP L3 soil moisture #19

wants to merge 2 commits into from

Conversation

RitwikGupta
Copy link
Member

No description provided.

@RitwikGupta
Copy link
Member Author

The SMAP data is large (675M for the H5 file). This may make tests fail due to a timeout on GitHub Actions. Any ideas @cjrd?

@cjrd
Copy link
Contributor

cjrd commented Sep 8, 2022

For the test, I think it's fine to just download and inspect the metadata asset. At least it's pulling something from the servers, so it'll still be a smoke test on the collection.

@RitwikGupta
Copy link
Member Author

@cjrd but then the notebook is not able to show a proper plot, or at least the integration test will fail on the plotting step. So far the tests are running okay without failure.

@cjrd
Copy link
Contributor

cjrd commented Sep 8, 2022

how about wrapping the big data download and plotting in a

if False:
   # change to True to download 600mb+ data and plot results

I don't think we want the tests to download that much data (even if they pass). This way ^^^ we can download the metadata and check it and have a nice plotting functionality for anyone looking to experiment with this data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants