Clean code

bakdata · Sep 18, 2023 · 71eb829 · 71eb829
1 parent ba0a355
commit 71eb829
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 14 deletions.
diff --git a/.github/workflows/java-gradle-release.yaml b/.github/workflows/java-gradle-release.yaml
@@ -63,7 +63,7 @@ jobs:
     steps:
       - name: Release on Github
         id: release
-        uses: bakdata/ci-templates/actions/java-gradle-release@feat/changelog-def
+        uses: bakdata/ci-templates/actions/java-gradle-release@1.33.0
         with:
           release-type: ${{ inputs.release-type }}
           github-email: ${{ secrets.github-email }}

diff --git a/actions/changelog-generate/README.md b/actions/changelog-generate/README.md
@@ -70,16 +70,16 @@ Additional configuration options can be explored
 
 ## Input Parameters
 
-| Name                      | Required | Default Value  | Description                                                                                                                                                  |
-| ------------------------- | :------: | :------------: | ------------------------------------------------------------------------------------------------------------------------------------------------------------ |
-| github-token              |    ✅    |       -        | The GitHub token for committing the changes                                                                                                                  |
-| new-tag                   |    ✅    |       -        | Defines until which tag the changelog will consider merged pull requests (can be a tag or a valid git ref)                                                   |
-| changelog-file            |    ❌    | "CHANGELOG.md" | Path to the Changelog.md file                                                                                                                                |
-| commit-mode               |    ❌    |    "false"     | Special configuration for projects which work without PRs. Uses commit messages as changelog. This mode looses access to information only available for PRs. |
-| config                    |    ❌    |       ""       | Path to the changelog config JSON file                                                                                                                       |
-| fetch-release-information |    ❌    |    "false"     | Will enable fetching additional release information from tags.                                                                                               |
-| fetch-reviewers           |    ❌    |    "false"     | Will enable fetching the users/reviewers who approved the PR.                                                                                                |
-| old-tag                   |    ❌    |       ""       | Defines the 'start' from where the changelog will consider merged pull requests (can be a tag or a valid git ref)                                            |
+| Name                      | Required |                Default Value                | Description                                                                                                                                                  |
+| ------------------------- | :------: | :-----------------------------------------: | ------------------------------------------------------------------------------------------------------------------------------------------------------------ |
+| github-token              |    ✅    |                      -                      | The GitHub token for committing the changes                                                                                                                  |
+| new-tag                   |    ✅    |                      -                      | Defines until which tag the changelog will consider merged pull requests (can be a tag or a valid git ref)                                                   |
+| changelog-file            |    ❌    |               "CHANGELOG.md"                | Path to the Changelog.md file                                                                                                                                |
+| commit-mode               |    ❌    |                   "false"                   | Special configuration for projects which work without PRs. Uses commit messages as changelog. This mode looses access to information only available for PRs. |
+| config                    |    ❌    | "$GITHUB_ACTION_PATH/changelog-config.json" | Path to the changelog config JSON file                                                                                                                       |
+| fetch-release-information |    ❌    |                   "false"                   | Will enable fetching additional release information from tags.                                                                                               |
+| fetch-reviewers           |    ❌    |                   "false"                   | Will enable fetching the users/reviewers who approved the PR.                                                                                                |
+| old-tag                   |    ❌    |                     ""                      | Defines the 'start' from where the changelog will consider merged pull requests (can be a tag or a valid git ref)                                            |
 
 ## Outputs
 

diff --git a/actions/changelog-generate/action.yaml b/actions/changelog-generate/action.yaml
@@ -78,8 +78,6 @@ runs:
       shell: bash
 
     - name: "Create changelog"
-      env:
-        CONFIG_PATH: ${{ inputs.config }}
       id: build_changelog
       uses: mikepenz/release-changelog-builder-action@v4
       with:

diff --git a/actions/java-gradle-release/action.yaml b/actions/java-gradle-release/action.yaml
@@ -83,7 +83,7 @@ runs:
 
     - name: Create changelog
       id: build-changelog
-      uses: bakdata/ci-templates/actions/changelog-generate@feat/changelog-def
+      uses: bakdata/ci-templates/actions/changelog-generate@1.33.0
       with:
         github-token: ${{ inputs.github-token }}
         new-tag: ${{ steps.bump-version.outputs.release-version }}