add fork test for PRIME#140
Merged
Merged
Conversation
PRIME reads its rate from a Hastra FeedVerifier (Chainlink Data Streams) with a 1-hour staleness window. The base test's hardcoded skip(1 days) pushed the cached report past that limit, reverting the rate path and failing 13/17 tests. Add a `skipTime` field to ERC4626SetupState (defaults to 1 day, so all existing tokens are unchanged) and override it to 30 minutes for PRIME to keep the feed fresh. All 17 PRIME tests now pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PRIME (Hastra) is a staked-wYLDS ERC4626, available at https://hastra.io
Contract: https://etherscan.io/token/0x19ebb35279a16207ec4ba82799cc64715065f7f6
Heads up: this test currently FAILS (4 pass / 13 fail). All failures are the same StalePrice revert from PRIME's rate path. PRIME does not compute its rate from vault balances; it reads a Chainlink Data Streams feed via a Hastra FeedVerifier (proxy 0xdF4ab20fA7752Be52E41e42F1FD667f37964d6a3) whose defaultMaxStaleness is 3600s (1h). The base test's
skip(1 days)pushes the cached report ~24h past that limit, so convertToShares/convertToAssets revert. Opening to observe the same failures against CI's RPC while we evaluate boosted compatibility.