feat: add nighttime weather icons based on sunrise/sunset - #140
Merged
Conversation
Display moon/night icons when the current time is after sunset or before sunrise. For current weather, use the is_day field from the Open-Meteo API. For hourly forecasts, request daily sunrise/sunset data and compare each hour against those times. - Add IsDay property to CurrentWeather model - Add sunrise/sunset to DailyForecast and HourlyDailyInfo models - Add nighttime icon variants (ClearSkyNight, MainlyClearNight, etc.) - Update GetIconForWeatherCode with optional isNight parameter - Update all callers to pass night state Closes #138 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Displays moon/night icons when the current time is after sunset or before sunrise, addressing the issue where the sun icon was displayed at night.
Changes
IsDayproperty toCurrentWeather,Sunrise/SunsettoDailyForecast, and newHourlyDailyInfoclass for hourly forecast sunrise/sunset datais_day(current weather),sunrise,sunset(forecast and hourly forecast)ClearSkyNight(🌙),MainlyClearNight(🌙),PartlyCloudyNight(☁️), andWeatherIconNight(🌙) variantsGetIconForWeatherCodewith an optionalisNightparameter that selects night variants for clear/partly cloudy conditionsPinnedWeatherBand,WeatherDetailPage,WeatherListPageusecurrent.IsDay == 0HourlyForecastPagecompares each hour against sunrise/sunset timesDesign decisions
Closes #138