Fix dock band not updating after sleep/hibernation - #141
Merged
Conversation
After the system resumes from sleep or hibernation, an in-flight HTTP request could hold the _isUpdating re-entrancy guard indefinitely, blocking all subsequent timer ticks from refreshing the band's title/subtitle. The System.Timers.Timer also may not fire immediately on resume, leaving stale weather data displayed. Subscribe to SystemEvents.PowerModeChanged and, on Resume: - Cancel the stale CancellationTokenSource and swap in a fresh one - Reset _isUpdating so the next update is not blocked - Restart the timer for a clean interval - Immediately trigger UpdateWeatherAsync for fresh data Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After the system resumes from sleep or hibernation, the dock band for a pinned location stops updating its title/subtitle with fresh weather data.
Root cause: An in-flight HTTP request at the time of sleep could hold the
_isUpdatingre-entrancy guard indefinitely (1), blocking all subsequent timer ticks from executingUpdateWeatherAsync. Additionally,System.Timers.Timerdoesn't guarantee an immediate tick on resume, leaving stale data displayed.Fix
Subscribe to
SystemEvents.PowerModeChangedinPinnedWeatherBandand onResume:CancellationTokenSourceand swap in a fresh one (viaInterlocked.Exchange)_isUpdatingto0so updates aren't blockedUpdateWeatherAsync()for fresh weather dataThe handler is properly unsubscribed in
Dispose().Testing
All 296 existing tests pass. The structural/IL-level tests in
DockBandCardSyncTestscontinue to validate the timer and content-page sync contracts.