-
Notifications
You must be signed in to change notification settings - Fork 5
Refactor, eslint, Skip, dry-run and prefix features #4
base: master
Are you sure you want to change the base?
Refactor, eslint, Skip, dry-run and prefix features #4
Conversation
… files into lib folder. Added eslint and Changelog.
Managed to miss a few things. So not ready to merge yet. Will fix up today. |
This should be in a good state now and almost ready to merge. I added some of the new syntax to the README and now have also all new command additions unit and/or accpetance/integration tested. Another thing to note, this now only supports node >=0.12.0 and io.js >= 1.0.0 since it is using native Promises. Also for tests I am using babeljs to get the much nice ES6/7 syntax. This is done via: require('babel/register')({
experimental: true,
loose: true
}); in the Now writing that all down tells me I should find a solution that babel ignores certain folders. So probably best to wait for that before merging. |
Now waiting on babel/babel#1134 and can think of implementing eslint/eslint#2217 / http://eslint.org/docs/user-guide/configuring#configuration-cascading-and-hierarchy |
@mikermcneil Let me know what you think about these changes - I am happy to explain to you all the changes in more details. If so I would just do the last clean-ups and it would be ready to merge. |
Since I recently learned quite a bit about tests I thought I would use this knowledge to refactor enpeem and improve the test situation a bit.
This primarily fixes #3 but also adds https://github.com/eslint/eslint, wraps now everything into Promises and simplified a few things.
Let me know what you think @mikermcneil .