Support VK_EXT_physical_device_drm #3467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misyltoad
force-pushed
the
VK_EXT_physical_device_drm
branch
from
9ff742e to
c03544b
Compare
baldurk
reviewed
Oct 29, 2024
| @@ -1456,6 +1456,10 @@ SERIALISE_VK_HANDLES(); | |||
| PNEXT_STRUCT(VK_STRUCTURE_TYPE_SUBPASS_FRAGMENT_DENSITY_MAP_OFFSET_END_INFO_QCOM, \ | |||
| VkSubpassFragmentDensityMapOffsetEndInfoQCOM) \ | |||
| \ | |||
| /* VK_EXT_physical_device_drm */ \ | |||
| PNEXT_STRUCT(VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_DRM_PROPERTIES_EXT, \ | |||
| VkPhysicalDeviceDrmPropertiesEXT) \ | |||
There was a problem hiding this comment.
nit: these extensions are listed in alphabetical order (and in EXT/KHR tag groups) could you move this up?
baldurk
requested changes
Nov 4, 2024
|
Closing this due to lack of activity from the PR author and no response to feedback. If you are the author and you'd like to revisit this change please open a new PR and address the feedback above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the VK_EXT_physical_device_drm extension.