Add Env support #369
Merged
Add Env support #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuruddhal
force-pushed
the
env
branch
3 times, most recently
from
8ad5973
to
22dba80
Compare
hemikak
reviewed
Mar 11, 2020
| import static org.ballerinax.docker.test.utils.DockerTestUtils.getExposedPorts; | ||
|
|
||
| /** | ||
| * Build with `buildImage` field set to false and check whether build command is shown. |
There was a problem hiding this comment.
Need to update the comment.
hemikak
reviewed
Mar 11, 2020
| @@ -301,6 +304,9 @@ private String generateDockerfileForWindows() { | |||
| .append(FilenameUtils.separatorsToWindows(file.getTarget())) | |||
| .append("\n"); | |||
| }); | |||
| dockerModel.getEnv().forEach((key, value) -> { | |||
There was a problem hiding this comment.
Shall we keep an empty line above ?
hemikak
reviewed
Mar 11, 2020
| Map<String, String> env = new HashMap<>(); | ||
| env.put("PASSWORD", "myP@$$worD"); | ||
| setEnv(env); | ||
| ProcessOutput buildProcess = DockerTestUtils.compileBallerinaFile(sourceDirPath, "env.bal"); |
There was a problem hiding this comment.
DockerTestUtils.compileBallerinaFile() function uses a process builder. I think we can pass env vars to the process so that the above setEnv function is not needed.
Codecov Report
@@ Coverage Diff @@
## master #369 +/- ##
============================================
- Coverage 65.53% 65.09% -0.44%
- Complexity 176 183 +7
============================================
Files 14 14
Lines 824 851 +27
Branches 114 119 +5
============================================
+ Hits 540 554 +14
- Misses 220 231 +11
- Partials 64 66 +2
Continue to review full report at Codecov.
|
hemikak
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose