Repository navigation
fix: buffer SSE response reads - #2742
Draft
Anuja-jayasinghe wants to merge 1 commit into
Draft
Anuja-jayasinghe wants to merge 1 commit into
Anuja-jayasinghe wants to merge 1 commit into
Conversation
Signed-off-by: Anuja Jayasinghe <anujajayasinhe@gmail.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Purpose
This draft fixes the HTTP client's poor performance when reading large SSE events.
getSseEventStreamcurrently requests one-byte chunks and performs one stream read for every byte while looking for the SSE event delimiter. This makes a 2 MB SSE event take several seconds even though the same data as a unary response is read in well under a second.The change uses the normal buffered response stream and retains unread bytes locally. The parser still handles fragmented input and delimiters split across chunks, including one-byte chunks, without forcing every read to be one byte.
Examples
The repository's existing hostile-server
s_hugecase sends a 2,000,000-byte artifact in one SSE event. The same server also exposes the payload asu_hugein a unary response.The buffered reader returned the complete payload: 2,000,000 artifact bytes and 2,000,476 bytes including SSE framing. An integration test also covers a 64 KiB SSE event and verifies that the payload is not truncated.
Checklist