Add IBM MQ connector functionality #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ayesh Almeida <[email protected]>
Add basic pub sub support
Add point-to-point messaging capabilities with IBM MQ queue support
ayeshLK
requested review from
shafreenAnfar,
NipunaRanasinghe and
dilanSachi
as code owners
Update doc-comment for the class
Add `close` and `disconnect` apis
Refactor IBM MQ destination API
Remove restrictions added on option types
This reverts commit 62017d1.
Properly set native IBM MQ queue in the ballerina IBM MQ queue
|
APIs looks good to me. |
shafreenAnfar
previously approved these changes
Oct 30, 2023
Add basic pub sub tests
dilanSachi
previously approved these changes
Oct 30, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
=======================================
Coverage ? 56.47%
Complexity ? 25
=======================================
Files ? 11
Lines ? 301
Branches ? 34
=======================================
Hits ? 170
Misses ? 125
Partials ? 6 ☔ View full report in Codecov by Sentry. |
dilanSachi
force-pushed
the
connector-implementation
branch
from
cbcc5a2
to
0d6043f
Compare
dilanSachi
force-pushed
the
connector-implementation
branch
from
0d6043f
to
84aad43
Compare
shafreenAnfar
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Part of: #5084