Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Fix bug when return type is byte[] in OpenAPI spec generation #1469

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

aneeshafedo
Copy link
Contributor

Purpose

$subject
Resolves ballerina-platform/ballerina-library#5282

Security checks

Test environment

Java JDK 11

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06% 🎉

Comparison is base (96e88ba) 78.78% compared to head (4817f44) 78.84%.
Report is 41 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    ballerina-platform/openapi-tools#1469      +/-   ##
============================================
+ Coverage     78.78%   78.84%   +0.06%     
- Complexity     1684     1697      +13     
============================================
  Files           124      124              
  Lines          9815     9886      +71     
  Branches       1596     1616      +20     
============================================
+ Hits           7733     7795      +62     
- Misses         1513     1518       +5     
- Partials        569      573       +4     
Files Changed Coverage Δ
...java/io/ballerina/openapi/converter/Constants.java 73.86% <ø> (ø)
...enapi/converter/service/OpenAPIResponseMapper.java 83.40% <100.00%> (+0.25%) ⬆️
.../openapi/converter/utils/ConverterCommonUtils.java 57.01% <100.00%> (+1.14%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Aug 5, 2023
@lnash94 lnash94 removed the Stale label Aug 7, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lnash94 lnash94 changed the title Fix bug when return type is byte[] in OpenAPI spec generation [master] Fix bug when return type is byte[] in OpenAPI spec generation Aug 10, 2023
@NipunaRanasinghe NipunaRanasinghe merged commit d0b7856 into ballerina-platform:master Aug 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid mediaType: byte error when there exists byte[] as the return type in the resource function
3 participants