-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the sanitization logic in the auto-generated names #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TharmiganK
force-pushed
the
fix-header-query-gen
branch
from
September 5, 2024 05:48
266df5d
to
2c847a4
Compare
# Conflicts: # openapi-core/src/main/java/io/ballerina/openapi/core/generators/client/parameter/HeadersParameterGenerator.java
TharmiganK
requested review from
lnash94,
daneshk and
shafreenAnfar
as code owners
September 5, 2024 10:19
...ain/java/io/ballerina/openapi/core/generators/client/AbstractFunctionSignatureGenerator.java
Show resolved
Hide resolved
ayeshLK
reviewed
Sep 6, 2024
...ain/java/io/ballerina/openapi/core/generators/client/AbstractFunctionSignatureGenerator.java
Outdated
Show resolved
Hide resolved
...gration-tests/src/test/resources/service/return/ballerina/content_schema_has_one_of_type.bal
Show resolved
Hide resolved
lnash94
reviewed
Sep 11, 2024
...ain/java/io/ballerina/openapi/core/generators/client/AbstractFunctionSignatureGenerator.java
Outdated
Show resolved
Hide resolved
lnash94
previously approved these changes
Sep 11, 2024
…s/client/AbstractFunctionSignatureGenerator.java Co-authored-by: Sumudu Nissanka <[email protected]>
Quality Gate passedIssues Measures |
lnash94
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes: ballerina-platform/ballerina-library#6961
Fixes: ballerina-platform/ballerina-library#6960