Skip to content
This repository has been archived by the owner on Jun 3, 2020. It is now read-only.

Sidebar Element as Semantic HTML (Nav) #139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joeflack4
Copy link
Contributor

Added ability for root element to be either non-semantic html (div) or semantic html (nav).

@markusenglund
Copy link
Collaborator

Is there a way to let the user set the sidebar to any tag they want instead? It seems to me like the <aside> tag is often a good choice for a sidebar, and there might be other tags that make sense under certain conditions.

@markusenglund
Copy link
Collaborator

You know, as I think more about this it seems kind of unnecessary to let users of the library decide what the root sidebar tag should be. They can just as well create a <nav> tag inside the sidebar-div. I think that's just as good from an a11y-perspective.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants