Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .changeset/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"ignore ": [["@baloise/ds-output-target-*", "@baloise/ds-nx", "e2e", "docs"]],
"linked": [],
"access": "public",
"baseBranch": "main",
"baseBranch": "release/v20",
"updateInternalDependencies": "patch",
"ignore": [],
"___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH": {
Expand Down
37 changes: 37 additions & 0 deletions .changeset/popular-dolls-sing.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
---
'@baloise/ds-core': major
---

**angular**: The design system now provides an Angular provider instead of the BaloiseDesignSystemModule.

This change simplifies maintenance, ensures the Angular library stays up to date, and removes support for deprecated or optional Angular parts.

The new provider is fully compatible with both Angular module-based applications and the latest Angular solutions.

**How to migrate**

1. In the app-module.ts replace the `BaloiseDesignSystemModule.forRoot(<config>)` with the provide function `provideBaloiseDesignSystem(<config>)`. `<config>` is the same type as before.

```ts
@NgModule({
declarations: [App],
schemas: [CUSTOM_ELEMENTS_SCHEMA],
imports: [BrowserModule, AppRoutingModule, SharedModule],
providers: [provideBrowserGlobalErrorListeners(), provideBaloiseDesignSystem()],
bootstrap: [App],
})
export class AppModule {}
```

2. Remove the `BaloiseDesignSystemModule` in every other module and import the components you need instead or just all components with the bundle `BalComponentBundle`.

```ts
@NgModule({
imports: [BalComponentBundle],
// or component by component
// imports: [BrowserModule, AppRoutingModule, BalLayoutBundle, BalHeading, BalButton],
...
})
export class SharedModule {}
```
3. Make sure only to import and use `@baloise/ds-angular`.
28 changes: 28 additions & 0 deletions .changeset/pre.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
{
"mode": "pre",
"tag": "rc",
"initialVersions": {
"docs": "15.2.49",
"e2e": "15.2.49",
"@baloise/ds-nx": "19.8.3",
"@baloise/output-target-angular": "0.0.0",
"@baloise/output-target-web": "0.0.0",
"@baloise/ds-angular": "19.8.3",
"@baloise/ds-angular-common": "19.8.3",
"@baloise/ds-angular-module": "19.8.3",
"@baloise/ds-brand-icons": "19.8.3",
"@baloise/ds-core": "19.8.3",
"@baloise/ds-devkit": "19.8.3",
"@baloise/ds-favicons": "19.8.3",
"@baloise/ds-fonts": "19.8.3",
"@baloise/ds-icons": "19.8.3",
"@baloise/ds-maps": "19.8.3",
"@baloise/ds-playwright": "19.8.3",
"@baloise/ds-react": "19.8.3",
"@baloise/ds-styles": "19.8.3",
"@baloise/ds-table": "19.8.3",
"@baloise/ds-testing": "19.8.3",
"@baloise/ds-tokens": "19.8.3"
},
"changesets": []
}
5 changes: 5 additions & 0 deletions .changeset/thick-pianos-accept.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@baloise/ds-core': patch
---

**core**: improve slot handling
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
node_modules
dist
test
playwright-report

packages/icons/src/index.ts
packages/core/icons
7 changes: 0 additions & 7 deletions .github/workflows/actions/build/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,6 @@ runs:
output: packages/angular/src/Angular.zip
paths: packages/angular/src/generated

- uses: ./.github/workflows/actions/upload-archive
if: inputs.build == 'true'
with:
name: angular-module
output: packages/angular-module/src/AngularModule.zip
paths: packages/angular-module/src/generated

- uses: ./.github/workflows/actions/upload-archive
if: inputs.build == 'true'
with:
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/actions/framework-setup/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,6 @@ runs:
path: ./packages/angular/src
filename: Angular.zip

- uses: ./.github/workflows/actions/download-archive
with:
name: angular-module
path: ./packages/angular-module/src
filename: AngularModule.zip

- uses: ./.github/workflows/actions/download-archive
with:
name: testing-dist
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/continuous.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
strategy:
fail-fast: false
matrix:
apps: [v18, v19, v20]
apps: [v19, v20, v21]
needs: [build]
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -155,7 +155,7 @@ jobs:
HUSKY: 0
CI: 1
container:
image: mcr.microsoft.com/playwright:v1.50.1-noble
image: mcr.microsoft.com/playwright:v1.56.1-noble
options: --user 1001
strategy:
fail-fast: false
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ jobs:
HUSKY: 0
CI: true
container:
image: mcr.microsoft.com/playwright:v1.50.1-noble
image: mcr.microsoft.com/playwright:v1.56.1-noble
options: --user 1001
steps:
- name: Show inputs from pree job
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-shapshots.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
HUSKY: 0
CI: true
container:
image: mcr.microsoft.com/playwright:v1.50.1-noble
image: mcr.microsoft.com/playwright:v1.56.1-noble
options: --user 1001
steps:
- uses: actions/checkout@v4
Expand Down
95 changes: 68 additions & 27 deletions .github/workflows/visual-base.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,45 +4,86 @@ on:
workflow_dispatch:

jobs:
main:
name: 📸 Updating Screenshots
runs-on: ubuntu-latest
assembleInformation:
name: 📝 Assemble Information
runs-on: ubuntu-22.04
timeout-minutes: 30
env:
HUSKY: 0
CI: true
outputs:
action: ${{ steps.action.outputs.url }}
branch: ${{ steps.branch.outputs.branch }}
steps:
- name: Get Action URL
id: action
run: |
echo "url=https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}" >> $GITHUB_OUTPUT

- name: Get Branch Name
id: branch
# Determine branch reliably from the event payload.
# - For pull_request events use github.head_ref (the source branch name)
# - For push events parse GITHUB_REF (refs/heads/<branch>)
run: |
if [ "${{ github.event_name }}" = "pull_request" ]; then
echo "branch=${{ github.head_ref }}" >> $GITHUB_OUTPUT
else
# strip refs/heads/ prefix
BRANCH_NAME=${GITHUB_REF#refs/heads/}
echo "branch=$BRANCH_NAME" >> $GITHUB_OUTPUT
fi

playwright:
name: 🎭 Playwright
runs-on: ubuntu-22.04
timeout-minutes: 30
needs: [assembleInformation]
env:
HUSKY: 0
CI: 1
container:
image: mcr.microsoft.com/playwright:v1.56.1-noble
options: --user 1001
steps:
- name: Show inputs from previous job
run: |
echo "Branch from previous job: ${{ needs.assembleInformation.outputs.branch }}"
echo "Action: ${{ needs.assembleInformation.outputs.action }}"

- uses: actions/checkout@v4
with:
ref: ${{ needs.assembleInformation.outputs.branch }}
token: ${{ secrets.PRE_RELEASE_GITHUB_TOKEN }}
fetch-depth: 0
- uses: ./.github/workflows/actions/e2e-build
with:
build: true
token: ${{ secrets.GITHUB_TOKEN }}

- name: Run Cypress
uses: cypress-io/github-action@v6
with:
start: node ./web-server.js
wait-on: 'http://localhost:3333'
working-directory: e2e
install: false
browser: chrome
spec: |
cypress/e2e/visual/*.cy.ts
- uses: ./.github/workflows/actions/setup

- name: Clean Install
run: npm ci

- name: Build Core
run: npx nx run core:build
env:
CYPRESS_visualRegressionType: base
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
BAL_PLAYWRIGHT_TESTING: 'true'

- name: Upload snapshots
if: failure()
uses: actions/upload-artifact@v4
with:
name: cypress-snapshots
path: e2e/cypress/snapshots
- name: Run Playwright tests
run: npx nx run core:ci-e2e -- --update-snapshots
env:
BAL_PLAYWRIGHT_TESTING: 'true'

- name: Commit base images
- name: Commit snapshots
if: always()
uses: EndBug/add-and-commit@v9
with:
message: 'update base images'
message: 'update snapshots'
env:
GITHUB_TOKEN: ${{ secrets.PRE_RELEASE_GITHUB_TOKEN }}

- name: Upload Playwright HTML report
if: always()
uses: actions/upload-artifact@v4
with:
name: playwright-report-shard-${{ matrix.shardIndex }}
path: packages/core/playwright-report
retention-days: 7
24 changes: 12 additions & 12 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,12 @@ e2e/cypress/snapshots/diff
e2e/cypress/snapshots/report.html
e2e/cypress/downloads

resources/data
!resources/data/tags.json
resources/data/commands.json
resources/data/contributors.json
resources/data/selectors.json

docs/stories/contributing/contributors.md
docs/stories/development/00-guides/theming/theming.md
docs/src/contributing/contributors.md
docs/src/development/00-guides/theming/theming.md
docs/public/assets/fonts/
docs/public/assets/data/
docs/public/assets/download/
Expand All @@ -99,9 +100,12 @@ docs/public/build/
docs/public/assets/images/map-markers
docs/public/assets/images/brand-icons
docs/public/assets/images/icons
docs/stories/assets/data
docs/stories/components/**/api.md
docs/src/assets/data
docs/src/components/**/api.md
docs/src/components/**/theming.md
docs/src/components/**/testing.md
docs/dist
docs.old/

test/angular/*
!test/angular/base
Expand All @@ -119,8 +123,6 @@ test/react/*

packages/brand-icons/CHANGELOG.md
packages/devkit/CHANGELOG.md
packages/angular-common/CHANGELOG.md
packages/angular-module/CHANGELOG.md
packages/angular/CHANGELOG.md
packages/react/CHANGELOG.md
packages/table/CHANGELOG.md
Expand All @@ -141,8 +143,6 @@ e2e/CHANGELOG.md
packages/core/README.md
packages/brand-icons/README.md
packages/devkit/README.md
packages/angular-common/README.md
packages/angular-module/README.md
packages/angular/README.md
packages/react/README.md
packages/table/README.md
Expand All @@ -163,8 +163,6 @@ e2e/README.md
packages/core/LICENSE
packages/brand-icons/LICENSE
packages/devkit/LICENSE
packages/angular-common/LICENSE
packages/angular-module/LICENSE
packages/angular/LICENSE
packages/react/LICENSE
packages/table/LICENSE
Expand All @@ -189,3 +187,5 @@ vitest.config.*.timestamp*
*-darwin.png
test-results
playwright.visual.config.ts
.cursor/rules/nx-rules.mdc
.github/instructions/nx.instructions.md
10 changes: 6 additions & 4 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,18 @@ CHANGELOG_v12.md
generated

docs/public
docs/stories/assets
docs/stories/components/**/api.md
docs/stories/components/**/testing.md
docs/stories/components/**/theming.md
docs/src/assets
docs/src/components/**/api.md
docs/src/components/**/testing.md
docs/src/components/**/theming.md

e2e/cypress/snapshots
e2e/cypress/videos
e2e/cypress/downloads

package-lock.json
*.svg
*.mdx
resources/data/components.json

/.nx/workspace-data
5 changes: 5 additions & 0 deletions .stylelintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
packages/fonts/
styles/
docs/
test/
e2e/
28 changes: 0 additions & 28 deletions .verdaccio/config.yml

This file was deleted.

7 changes: 1 addition & 6 deletions .vscode/extensions.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
{
"recommendations": [
"nrwl.angular-console",
"esbenp.prettier-vscode",
"firsttris.vscode-jest-runner",
"ms-playwright.playwright"
]
"recommendations": ["nrwl.angular-console", "esbenp.prettier-vscode", "ms-playwright.playwright"]
}
Loading
Loading