Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tunnel] implement route - router #495

Open
wants to merge 28 commits into
base: tunnel-ibc-hook
Choose a base branch
from

Conversation

satawatnack
Copy link
Member

@satawatnack satawatnack commented Nov 27, 2024

Implementation details

  • Add router route

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@satawatnack satawatnack requested a review from RogerKSI November 27, 2024 11:01
@RogerKSI RogerKSI changed the title [Tunnel] Add Router route [Tunnel] implement route - router Jan 9, 2025
@satawatnack satawatnack changed the base branch from master to tunnel-ibc-hook January 27, 2025 09:24
@satawatnack satawatnack marked this pull request as ready for review January 27, 2025 09:59
@satawatnack satawatnack requested a review from RogerKSI February 10, 2025 03:52
@satawatnack satawatnack requested a review from RogerKSI February 14, 2025 09:48
TunnelID: tunnelID,
Sequence: 1,
Prices: []feedstypes.Price{},
CreatedAt: time.Now().Unix(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can time be fixed?

// it will be padded with 0s at the beginning.
func stringToBytes32(str string) [32]byte {
maxLen := len(str)
if maxLen > 32 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we return error in case of string is over 32 bytes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants