Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add store object #33

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

add store object #33

wants to merge 13 commits into from

Conversation

nkitlabs
Copy link
Collaborator

@nkitlabs nkitlabs commented Feb 3, 2025

Fixed:

  • refactor app
  • add store object, separate os.readFile/write from the app object.

Implementation details

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@nkitlabs nkitlabs requested a review from RogerKSI February 4, 2025 10:31
@nkitlabs nkitlabs removed the request for review from RogerKSI February 4, 2025 10:59
@nkitlabs nkitlabs marked this pull request as ready for review February 5, 2025 03:13
@nkitlabs nkitlabs requested a review from RogerKSI February 5, 2025 03:13
@RogerKSI RogerKSI requested a review from tanut32039 February 13, 2025 03:46
@nkitlabs nkitlabs requested a review from RogerKSI February 14, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants