Skip to content

Fix a bug. #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bangerth merged 1 commit into from
Dec 16, 2024
Merged

Fix a bug. #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions include/sampleflow/producers/differential_evaluation_mh.impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,12 +233,14 @@ namespace SampleFlow
b_dist(0, n_chains - 3);

typename std::vector<OutputType>::size_type b = b_dist(rng);
if (b >= std::min<typename std::vector<OutputType>::size_type>(a, chain))
++b;
if (b >= std::max(a, chain))
b += 2;
else if (b >= std::min<typename std::vector<OutputType>::size_type>(a, chain))
b += 1;
++b;
const OutputType trial_b = current_samples[b];

assert (a!=b);

// Combine trial a and trial b
const OutputType crossover_result = crossover(current_samples[chain], trial_a, trial_b);
trial_sample_and_ratio = propose_sample(crossover_result);
Expand Down
2 changes: 1 addition & 1 deletion tests/differential_evaluation_mh_producer_01.output
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Mean value = 1.9881
Mean value = 1.98196
Loading