Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: vault-env -> secret-init, vault-secrets-webhook -> secrets-webhook #388

Merged
merged 3 commits into from
Mar 20, 2024
Merged

feat: vault-env -> secret-init, vault-secrets-webhook -> secrets-webhook #388

merged 3 commits into from
Mar 20, 2024

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Feb 28, 2024 •
edited
Loading

Overview

@csatib02 csatib02 added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 28, 2024
@csatib02 csatib02 requested a review from ramizpolic February 28, 2024 12:42
@csatib02 csatib02 self-assigned this Feb 28, 2024
@csatib02 csatib02 requested a review from a team as a code owner February 28, 2024 12:42
@github-actions github-actions bot added the size/XL Denotes a PR that changes 1000+ lines label Feb 28, 2024
@csatib02 csatib02 requested review from sagikazarmark and akijakya and removed request for a team February 28, 2024 12:44
akijakya
akijakya approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@akijakya akijakya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks! 😊

@csatib02 csatib02 merged commit e37243b into main Mar 20, 2024
54 checks passed
@csatib02 csatib02 deleted the feat/vault_env-to-secret_init branch March 20, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akijakya akijakya akijakya approved these changes

@ramizpolic ramizpolic Awaiting requested review from ramizpolic

@sagikazarmark sagikazarmark Awaiting requested review from sagikazarmark

Assignees

@csatib02 csatib02

Labels
kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 1000+ lines
Projects
Project backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csatib02 @akijakya