Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper implementation for BDSBAS #660

Closed
wants to merge 32 commits into from

Conversation

Narugakuruga
Copy link
Contributor

Add PNR 130, 143, 144 to carrier frequency test.
Add sky view flags using existing asset.
Update SbasType and string to match names. SNAS only exist in very old press release. So rename to BDSBAS now.

Hopefully it won't affect database too much. There's 20 records of "SNAS" right now. But the signal is marked as "testing, do not use" anyway. I wonder why these device is using them

  • Acknowledge that you're contributing your code under Apache v2.0 license

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

@Narugakuruga
Copy link
Contributor Author

@barbeau Glad to have your review Mr barbeau! I would like to know what went wrong with the CI

@barbeau
Copy link
Owner

barbeau commented Nov 1, 2023

@Narugakuruga you should be able to click through on the CI link that failed, and then just scrolled at the bottom of the CI log. It should show what errors prevented the build from completing. If you take a look and can't see the problem let me know and I'll take a closer look.

@Narugakuruga
Copy link
Contributor Author

Narugakuruga commented Nov 6, 2023

Sorry, I was trying to label the sbas as B2a, But the code is out putting L5. Can you please help me check what is wrong? I think I must miss something.

05.7221640Z com.android.gpstest.CarrierFreqUtilsTest > testGetCarrierFrequencyLabel[test(AVD) - 10] �[31mFAILED �[0m
2023-11-06T03:44:05.7222930Z junit.framework.ComparisonFailure: expected:<[B2a]> but was:<[L5]>
2023-11-06T03:44:05.7224260Z at junit.framework.Assert.assertEquals(Assert.java:85)
2023-11-06T03:44:06.8674750Z Tests on test(AVD) - 10 failed: There was 1 failure(s).
2023-11-06T03:44:07.9973330Z
2023-11-06T03:44:07.9979090Z > Task :GPSTest:connectedGoogleDebugAndroidTest FAILED

Copy link

stale bot commented May 25, 2024

This issue has been automatically marked as stale because it has not had recent activity. Please comment here if it is still valid so that we can reprioritize. Thank you!

@stale stale bot added the stale label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants