Show value of configuration in preferences for coordinate pref #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firebovine
force-pushed
the
coordinate_prefs
branch
from
044c8cc to
51bddbb
Compare
firebovine
changed the title
|
Thanks @firebovine! I'll review this soon. |
|
This issue has been automatically marked as stale because it has not had recent activity. Please comment here if it is still valid so that we can reprioritize. Thank you! |
barbeau
requested changes
Mar 27, 2025
| changePreferenceSummary(key) | ||
| } else { |
There was a problem hiding this comment.
Can you please make this an else if?
| @@ -277,6 +292,18 @@ class Preferences : PreferenceActivity(), OnSharedPreferenceChangeListener { | |||
| preferredSpeedUnits!!.summary = entries[i] | |||
| } | |||
| } | |||
| } else if (prefKey.equals( | |||
There was a problem hiding this comment.
The formatting for this seems off - can you please reformat this file?
|
Could you also please resolve the conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your pull request - thanks!
Acknowledge that you're contributing your code under Apache v2.0 license
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.