Fix slash in attachment file name issue #676
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some systems allow slash(/) in attachment file name, and it causes issue in IncomingMailAttachment::saveToDisk() function. The \file_put_contents() function cannot handle it and throws error Failed to open stream: No such file or directory
Sebbo94BY
requested changes
Dec 5, 2022
| @@ -1348,6 +1348,7 @@ public function downloadAttachment(DataPartInfo $dataInfo, array $params, object | |||
| $fileName = $this->decodeMimeStr($fileName); | |||
| $fileName = $this->decodeRFC2231($fileName); | |||
| } | |||
| $fileName = str_replace('/', ' ', $fileName); | |||
There was a problem hiding this comment.
I would feel better, if we would use a underscore instead of a whitespace as whitespaces can also result in unexpected behaviours.
Suggested change
| $fileName = str_replace('/', ' ', $fileName); | |
| $fileName = str_replace('/', '_', $fileName); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some systems allow slash(/) in attachment file name, and it causes issue in IncomingMailAttachment::saveToDisk() function. The \file_put_contents() function cannot handle it and throws error
Failed to open stream: No such file or directory