Validate DPOR data invariants #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm pretty sure I could make four of these invariants correct-by-construction by dropping the to-do, done, and taken sets, and turning the runnable set into a map from thread IDs to: data DPORThreadState = Todo Bool | Done (Maybe ThreadAction)"Make illegal states unrepresentable" and all that. But I worry this would complicate logic elsewhere. |
barrucadu
changed the title
barrucadu
force-pushed
the
dpor-invariants
branch
from
41cd6f0 to
ca0d7f6
Compare
barrucadu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Validates the DPOR data invariants & fixes an invariant violation in
incorporateTrace.grow, where the taken decision was not included in the runnable set.Related issues: #173
Checklist