Fix named arguments when using facade #1002
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #921
Demo: https://onlinephp.io/c/d34c3
lluminate/Support/Facades/Facade.php#L345-L353
This PR keeps multiple instances functionality
facade method conditional is no longer necessary, because it always pass thru, and PDF already validates that
laravel-dompdf/src/Facade/Pdf.php
Lines 66 to 68 in 3dbe06b
laravel-dompdf/src/PDF.php
Line 286 in 3dbe06b