[TESTS] Running in CI should not create but rather fail on missing snapshots #1039
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pshots Otherwise they get created on the CI infrastructure but that's it, the build won't fail although it was forgotten to add the snapshot.
The `prefer-lowest` version we get with L6 is 8.0.0 which throws this error: ``` PHP Fatal error: Uncaught TypeError: ini_set() expects parameter 2 to be string, bool given in /home/runner/work/laravel-ide-helper/laravel-ide-helper/vendor/phpunit/phpunit/src/TextUI/Command.php:379 ```
|
I made the phpunit version more explicit. Looks good otherwise |
barryvdh
approved these changes
Sep 7, 2020
Btw, I decided not to do that because the phpunit version is effectively dicdated by orchestra/testbench and the only goal was to make sure we don't use known broken version for our tests. Otherwise once we bump orchestra which supports phpunit 10 we might stay on 9 for no reason but this constraint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Otherwise they get created on the CI infrastructure but that's it, the
build won't fail although it was forgotten to add the snapshot.
Note: I had specify a minimum phpunit version, otherwise phpunit 8.0.0 would be installed for Laravel 6 and
prefer-lowest, which has the following bug with the-dparameter: