Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly resolve dependency paths #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Scradam
Copy link

@Scradam Scradam commented Aug 3, 2016

Changes:

  1. Use require.resolve() to correctly resolve paths to files in dependency packages (see node v0.8.0 docs)

This allows the package to correctly function when node_modules directory uses a maximally flat directory structure.

Testing:

  • Unit tests using npm run test all pass
  • Unit tests also pass with ./node_modules/handlebars moved to ../node_modules/handlebars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant