Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update rollup config flags to match optimism's recommendations #139

Merged
merged 1 commit into from
Nov 7, 2023
Merged

update rollup config flags to match optimism's recommendations #139

merged 1 commit into from
Nov 7, 2023

Conversation

roberto-bayardo
Copy link
Contributor

No description provided.

mdehoog
mdehoog reviewed Nov 6, 2023
View reviewed changes
geth-entrypoint Outdated Show resolved Hide resolved
@roberto-bayardo roberto-bayardo force-pushed the update-release-flags branch 2 times, most recently from 4119957 to 8cda002 Compare November 6, 2023 19:25
ghost
ghost reviewed Nov 7, 2023
View reviewed changes
geth-entrypoint
@@ -66,7 +53,7 @@ exec ./geth \
--nodiscover \
Copy link

@ghost ghost Nov 7, 2023 •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we remove the --gcmode=archive flag now? It is useless unless when you need to run a op-proposer or start tracing over historical states. op-geth will prune historical states without this flag and thus making the node more lighter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't want to expand the scope of this PR to other cleanup + I do worry that some users may already be relying on the default behavior to be archival (e.g. those running RPC nodes).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #146

@ghost
Copy link

ghost commented Nov 7, 2023

Also, I would like to recommend exposing --state.scheme option via an environment variable #132 (comment)

@roberto-bayardo
Copy link
Contributor Author

Also, I would like to recommend exposing --state.scheme option via an environment variable #132 (comment)

this is a good idea but will address it separately.

@roberto-bayardo roberto-bayardo merged commit 343455c into main Nov 7, 2023
3 checks passed
@roberto-bayardo roberto-bayardo deleted the update-release-flags branch November 7, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdehoog mdehoog mdehoog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roberto-bayardo @mdehoog