feat: add missing dependencies and improve documentation #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add required submodules: openzeppelin-contracts, solady, smart-wallet, magicspend - Update foundry.toml with proper remappings and formatting configuration - Replace template README with comprehensive project documentation - Remove outdated Counter.sol template files (Counter.t.sol, Counter.s.sol) The source code references these dependencies but they were not included as submodules, preventing the project from building. This commit adds all required dependencies and provides proper documentation for the Account Permissions protocol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes critical build issues and improves project documentation.
Changes
🔧 Fix: Add Missing Dependencies
The source code references several dependencies that were not included as submodules, preventing the project from building:
openzeppelin-contracts- Security utilities and token standardssolady- Gas-optimized Solidity utilities (EIP712, SignatureCheckerLib)smart-wallet- Coinbase Smart Wallet implementationmagicspend- Paymaster integration📝 Update: foundry.toml Configuration
cancunfor transient storage support📚 Improve: Project Documentation
🗑️ Cleanup: Remove Template Files
test/Counter.t.sol(unused Foundry template)script/Counter.s.sol(unused Foundry template)Note
There is a pre-existing Solidity version mismatch in the source code (
^0.8.28) vs smart-wallet dependency (=0.8.23) that will or should be addressed in a follow-up PR.