-
Notifications
You must be signed in to change notification settings - Fork 59
[BA-3103] Utility for converting a prolink to a base app deeplink #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🟡 Heimdall Review Status
|
|
feedback:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you post a screenshot of how the playground looks with these changes?
Looking great, couple comments to consider
| * Create a link with an encoded prolink query parameter and additional query parameters | ||
| * | ||
| * @param prolink - Base64url-encoded prolink payload | ||
| * @param baseUrl - Base URL to use for the link, defaults to https://base.app/base-pay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'baseUrl' is proper but feels overloaded because we are 'base' - is there a closeby synonym we can use like 'prefixUrl'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe just url? its scoped to the function so likely need a prefix
| * @param prolink - Base64url-encoded prolink payload | ||
| * @param baseUrl - Base URL to use for the link, defaults to https://base.app/base-pay | ||
| * @param additionalQueryParams - Additional query parameters to add to the link | ||
| * @returns { link: string } - Object containing the full link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preference for returning the string directly - let me know if you have thoughts in the other direction
Summary
prolinkToUniversalLinkprolinkandenvironmentHow did you test your changes?