Open
Conversation
Closes base#34 - Add devnet auto-detection when -c devnet is passed - Search for .devnet/basectl.yaml in current directory and parents - Add test for devnet config not found error
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34
What changed?
Added automatic devnet configuration detection when
-c devnetis passed to basectl.Implementation
basectl -c devnetis called, it searches for.devnet/basectl.yamlstarting from the current directory and traversing up to parent directoriesHow to test
just devnetin the base/base repo to start devnet.devnet/basectl.yamlwith your configbasectl -c devnetto verify auto detection worksTests
test_devnet_config_not_foundtest