Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 74 additions & 2 deletions crates/audit/src/archiver.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use crate::metrics::Metrics;
use crate::reader::EventReader;
use crate::storage::EventWriter;
use crate::reader::{EventReader, UserOpEventReader};
use crate::storage::{EventWriter, UserOpEventWriter};
use anyhow::Result;
use std::time::{Duration, Instant, SystemTime, UNIX_EPOCH};
use tokio::time::sleep;
Expand Down Expand Up @@ -78,3 +78,75 @@ where
}
}
}

pub struct KafkaUserOpAuditArchiver<R, W>
where
R: UserOpEventReader,
W: UserOpEventWriter + Clone + Send + 'static,
{
reader: R,
writer: W,
metrics: Metrics,
}

impl<R, W> KafkaUserOpAuditArchiver<R, W>
where
R: UserOpEventReader,
W: UserOpEventWriter + Clone + Send + 'static,
{
pub fn new(reader: R, writer: W) -> Self {
Self {
reader,
writer,
metrics: Metrics::default(),
}
}

pub async fn run(&mut self) -> Result<()> {
info!("Starting Kafka UserOp archiver");

loop {
let read_start = Instant::now();
match self.reader.read_event().await {
Ok(event) => {
self.metrics
.kafka_read_duration
.record(read_start.elapsed().as_secs_f64());

let now_ms = SystemTime::now()
.duration_since(UNIX_EPOCH)
.unwrap_or_default()
.as_millis() as i64;
let event_age_ms = now_ms.saturating_sub(event.timestamp);
self.metrics.event_age.record(event_age_ms as f64);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT of having the audit metrics separated by tags?

Similar to how we record metrics for RPC calls here: https://github.com/base/tips/blob/master/crates/ingress-rpc/src/metrics.rs#L5-L8 , and instead we can call it type (or a better name 😅)


let writer = self.writer.clone();
let metrics = self.metrics.clone();
tokio::spawn(async move {
let archive_start = Instant::now();
if let Err(e) = writer.archive_userop_event(event).await {
error!(error = %e, "Failed to write UserOp event");
} else {
metrics
.archive_event_duration
.record(archive_start.elapsed().as_secs_f64());
metrics.events_processed.increment(1);
}
});

let commit_start = Instant::now();
if let Err(e) = self.reader.commit().await {
error!(error = %e, "Failed to commit message");
}
self.metrics
.kafka_commit_duration
.record(commit_start.elapsed().as_secs_f64());
}
Err(e) => {
error!(error = %e, "Error reading UserOp events");
sleep(Duration::from_secs(1)).await;
}
}
}
}
}
Loading