Skip to content

Conversation

@wlawt
Copy link
Contributor

@wlawt wlawt commented Oct 23, 2025

Overview

This PR adds rpc support for send_bundle. The current validation logic is:

  • A bundle cannot be more than 1 hour into the future
  • A bundle cannot have 30M gas (totally changeable, just some placeholder)
  • All transactions in a bundle must be valid

Other changes:

The Kafka topic key was changed from a sender address to the bundle hash. This aligns across the APIs since a bundle can have transactions from different senders. Alternatively, we could have the sender of the bundle, but this seemed like the simplest solution.

Tests

  • CI
  • Added unit tests
  • Tested on devnet for behaviour changes on the refactor and everything is still the same

TODO

  • Validate transactions in a bundle
  • Implement: "If a bundle with the same bundle hash already exists the bundle will be combined with the existing one." of the API spec

Follow up PRs

  • Expand on bundle validation criteria
  • Enqueue BundleWithMetadata over EthSendBundle
  • Implement replace bundle within send_bundle
  • Implement e2e testing as such:
    • Update base/transaction-latency to do eth_sendBundle
    • Update base/infra-routing to support eth_sendBundle

@wlawt wlawt marked this pull request as ready for review October 23, 2025 18:33
@niran
Copy link
Contributor

niran commented Oct 23, 2025

LGTM

@wlawt wlawt merged commit 5b88139 into master Oct 23, 2025
10 checks passed
@wlawt wlawt deleted the create-bundle branch October 23, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants