[datastore]: handle insert scenario where bundle hash is the same #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses the API spec for the following scenario:
The assumptions are that the txs, txn_hashes, reverting_txs all remain the same. Properties that we "combine" would be the following (open to changing any of them):
The "combining" logic is simply just updating with the incoming bundle, for now. This can be changed later on.
Tests
insert_bundle_with_same_bundle_hashgenerate_txfn to uniquely generate different txns so that this change wouldn't break all the existing unit tests, as it was testing other functionalities, which I assumed the functionality was assuming bundles would have different hashes.