-
Notifications
You must be signed in to change notification settings - Fork 43
[ingress] introduce buffer queue #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| use alloy_primitives::Address; | ||
| use alloy_rpc_types_mev::EthSendBundle; | ||
| use anyhow::{Error, Result}; | ||
| use async_trait::async_trait; | ||
| use rdkafka::producer::{FutureProducer, FutureRecord}; | ||
| use tracing::{error, info}; | ||
|
|
||
| /// A queue to buffer transactions | ||
| #[async_trait] | ||
| pub trait QueuePublisher: Send + Sync { | ||
| async fn publish(&self, bundle: &EthSendBundle, sender: Address) -> Result<()>; | ||
| } | ||
|
|
||
| /// A queue to buffer transactions | ||
| pub struct KafkaQueuePublisher { | ||
| producer: FutureProducer, | ||
| topic: String, | ||
| } | ||
|
|
||
| impl KafkaQueuePublisher { | ||
| pub fn new(producer: FutureProducer, topic: String) -> Self { | ||
| Self { producer, topic } | ||
| } | ||
|
|
||
| pub async fn enqueue_bundle( | ||
| &self, | ||
| bundle: &EthSendBundle, | ||
| sender: Address, | ||
| ) -> Result<(), Error> { | ||
|
Comment on lines
+27
to
+31
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we add some retry logic with a backoff to this function? Maybe we can pull in this crate: |
||
| let key = sender.to_string(); | ||
| let payload = serde_json::to_vec(bundle)?; | ||
|
|
||
| let record = FutureRecord::to(&self.topic).key(&key).payload(&payload); | ||
|
|
||
| match self | ||
| .producer | ||
| .send(record, tokio::time::Duration::from_secs(5)) | ||
| .await | ||
| { | ||
| Ok((partition, offset)) => { | ||
| info!( | ||
| sender = %sender, | ||
| partition = partition, | ||
| offset = offset, | ||
| topic = %self.topic, | ||
| "Successfully enqueued bundle" | ||
| ); | ||
| Ok(()) | ||
| } | ||
| Err((err, _)) => { | ||
| error!( | ||
| sender = %sender, | ||
| error = %err, | ||
| topic = %self.topic, | ||
| "Failed to enqueue bundle" | ||
| ); | ||
| Err(anyhow::anyhow!("Failed to enqueue bundle: {}", err)) | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| #[async_trait] | ||
| impl QueuePublisher for KafkaQueuePublisher { | ||
| async fn publish(&self, bundle: &EthSendBundle, sender: Address) -> Result<()> { | ||
| self.enqueue_bundle(bundle, sender).await | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.