Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

[ENSIP 19] Update registration flow for SCWs - #2583

Merged
arjun-dureja merged 6 commits into
masterfrom
arjun/ensip19-registration
Sep 9, 2025
Merged

arjun-dureja merged 6 commits into
masterfrom
arjun/ensip19-registration

Conversation

@arjun-dureja

@arjun-dureja arjun-dureja commented Aug 15, 2025 •

Copy link
Copy Markdown
Collaborator

What changed? Why?

  • Updated the Basename registration flow to call the new contracts that support ENSIP19
    • This PR only updates the transaction made for smart accounts. A separate PR will be made for EOAs.
    • The transaction bundles two calls - one for calling register on the UpgradeableRegistrarController, and one for calling setName on the L2ReverseRegistrar
  • Also updated anywhere that we're calling the old register contract to call the new one

Notes to reviewers

How has it been tested?

Screen.Recording.2025-09-09.at.6.14.22.PM.mov

Have you tested the following pages?

BaseWeb

  • [] base.org
  • [] base.org/names
  • [] base.org/builders
  • [] base.org/ecosystem
  • [] base.org/name/jesse
  • [] base.org/manage-names
  • [] base.org/resources

@cb-heimdall

cb-heimdall commented Aug 15, 2025 •

Copy link
Copy Markdown
Collaborator

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel

vercel Bot commented Aug 15, 2025 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
base-web Ready Ready Preview Comment Sep 9, 2025 11:10pm

@arjun-dureja arjun-dureja changed the title Update registration flow for SCWs for ensip 19 [ENSIP 19] Update registration flow for SCWs Aug 15, 2025
stevieraykatz
stevieraykatz previously approved these changes Sep 9, 2025
@cb-heimdall
cb-heimdall dismissed stevieraykatz’s stale review September 9, 2025 22:58

Approved review 3203570777 from stevieraykatz is now dismissed due to new commit. Re-request for approval.

Comment on lines +2 to +3
// Temporarily hardcoded from RegistrarController
return { data: 1724184000n };

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arjun-dureja
arjun-dureja merged commit 27e86d7 into master Sep 9, 2025
11 checks passed
@arjun-dureja
arjun-dureja deleted the arjun/ensip19-registration branch September 9, 2025 23:18

This branch was successfully deployed

1 active deployment
Preview — a8a20284 Deployed Sep 9, 2025 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants