Skip to content

Conversation

@idrista
Copy link

@idrista idrista commented Feb 22, 2025

Support secret lookup for key_data

What’s changed?

  • key_data can now be a string to reference a secret, just like registry.username and registry.password.
  • To avoid breaking changes, the behavior is reversed compared to registry:
    • Registry.username | Registry.password : Array → lookup secret, String → raw value
    • SSH.key_data: Array → raw value, String → lookup secret

Why?

  • This makes it easier to manage SSH keys securely using .kamal/secrets.
  • Avoids exposing sensitive data in Git.

@idrista idrista marked this pull request as draft February 22, 2025 22:29
@idrista idrista marked this pull request as ready for review February 22, 2025 23:22
@lucashfreitas
Copy link

would be very nice!

@djmb
Copy link
Collaborator

djmb commented Nov 28, 2025

Superseded by #1620

@djmb djmb closed this Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants