Fix flawed handling of 404 messages#121
Conversation
Initial fix was flawed due to the fact that it dropped entirely the 404 message received from the server. This is a serious breaking change and shouldn't have had happened. The initial issue lies inside the fetchAll logic and it's wait logic and there the 404 handling should be.
|
@ro0NL I would appreciate to test if this fixes your test suite before merging |
|
hi @chazzbg maybe you have a workaround for that case? UPD i note that 404 msg was cherry-picked to legacy versions, so answer also can be 408. |
|
i believe this is related to this issue nats-io/nats-server#5373 . I've tested with the last version only and i believe that's why i didn't caught it. I believe that catching 408 also is fine in this case. Either way fetch loop needs to be exited |
Initial fix #120 was flawed due to the fact that it dropped entirely the 404 message received from the server. This is a serious breaking change and shouldn't have had happened. The initial issue lies inside the fetchAll and it's wait logic and therefore the handling of 404 should be there also.