Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for upper case extension file PDFs #10

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

cegea
Copy link
Contributor

@cegea cegea commented Sep 17, 2024

Some CAD programs such as Altium Designer generates PDF files with *.SCH instead of *.sch so the FilesOptions class would rise an exception raise ValueError("Input must be a pdf file or a directory.") even though the file exists.

To test it:

@ test_add_watermark_from_options.py: Change INPUT = "tests/fixtures/input.pdf" to INPUT = "tests/fixtures/input.PDF"

@bastienlc
Copy link
Owner

LGTM, thanks for the PR!

@bastienlc bastienlc merged commit 6ec82ad into bastienlc:master Sep 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants