Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add color argument for fa icons #662

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

p0lycarpio
Copy link

@p0lycarpio p0lycarpio commented Jun 24, 2023

Description

This PR adds the possibility to choose the color of an icon on a tile using the "color" attribute in config.yml file.

Fixes #406

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes to the documentation (README.md).
  • I've checked my modifications for any breaking changes, especially in the config.yml file

@netlify
Copy link

netlify bot commented Jun 24, 2023

Deploy Preview for homer-demo-content ready!

Name Link
🔨 Latest commit 6d66fba
🔍 Latest deploy log https://app.netlify.com/sites/homer-demo-content/deploys/649753b617401900085bc4d3
😎 Deploy Preview https://deploy-preview-662--homer-demo-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@dmyoung9 dmyoung9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me locally, and even for MDI icons!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon color per tile
2 participants