Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helm charts for homer #711

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kmjayadeep
Copy link

Description

Currently helm charts for homer is maintained in a different repository. That makes it difficult to keep the versions updated and contribute new changes.
In this PR i would like to introduce a simple helm chart with easy to understand configuration and no dependencies. If the PR is accepted, I would like to contribute follow-up PRs for the following,

  1. Add documentation for values file, update Readme
  2. If the repo owner would like to collaborate, i can help setup the pipeline to build and publish the charts on each release
  3. Contribute a new feature: Variable substitution in config files from env variables

I deploy homer though fluxcd gitops and my manifests are open source: https://github.com/kmjayadeep/homelab-k8s
Since it is public, i need a way to avoid hard-coding credentials in the configuration. So my idea is to introduce an init container which can substitute variables in the configuration. Then I can pass the credentials as env variables from a sealed secret. The alternative is to mount the whole config from a sealed secret, but it would be more user friendly to separate the credentials as variables.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes to the documentation (README.md).
  • I've checked my modifications for any breaking changes, especially in the config.yml file

I'm skipping the README.md update in this PR, since this chart needs to be published first before we do that.

Signed-off-by: Jayadeep KM <[email protected]>
@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for homer-demo-content ready!

Name Link
🔨 Latest commit ba8066b
🔍 Latest deploy log https://app.netlify.com/sites/homer-demo-content/deploys/65257009486f550008da5e9c
😎 Deploy Preview https://deploy-preview-711--homer-demo-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant