Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up deploy previews #749

Merged

Conversation

daniel-simpson
Copy link
Contributor

Description

Fixes: #748, deploy previews broken

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes to the documentation (README.md).
  • I've checked my modifications for any breaking changes, especially in the config.yml file

Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for homer-demo-content ready!

Name Link
🔨 Latest commit 4fa7bcc
🔍 Latest deploy log https://app.netlify.com/sites/homer-demo-content/deploys/667bac7020e715000889a2c3
😎 Deploy Preview https://deploy-preview-749--homer-demo-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@daniel-simpson
Copy link
Contributor Author

Proof is in the deploy preview :)

The autobuilt deploy preview is working: https://deploy-preview-749--homer-demo-content.netlify.app/ 🥳

Copy link
Owner

@bastienwirtz bastienwirtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

Thanks for your contribution @daniel-simpson! I like the idea of copying the dummy-data directly in the dist folder, I don't know why I haven't thought about it. I'll adjust some little things (mainly the new build command), and we will be good to go.

@bastienwirtz
Copy link
Owner

I ended up updating the build config on netlify settings for now, there is other settings and like to have it all in one place.

@bastienwirtz bastienwirtz merged commit 2b83a38 into bastienwirtz:main Jun 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netlify Deploy Preview not working for incoming PRs
2 participants