Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Home Assistant #783

Merged
merged 8 commits into from
May 22, 2024
Merged

Adding support for Home Assistant #783

merged 8 commits into from
May 22, 2024

Conversation

emilywotruba
Copy link
Contributor

Description

Created new custom service for Home Assistant and added documentation.
Allows displaying the name and version of the instance, as well as the count of entities:

screenshot

Fixes # N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes to the documentation (README.md).
  • I've checked my modifications for any breaking changes, especially in the config.yml file

Copy link

netlify bot commented May 20, 2024

Deploy Preview for homer-demo-content failed.

Name Link
🔨 Latest commit 6c9b802
🔍 Latest deploy log https://app.netlify.com/sites/homer-demo-content/deploys/664cff0e31d88e00083d52a5

Copy link
Owner

@bastienwirtz bastienwirtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @emilywotruba!
A small issue to fix on the data fetching and we should be good to go.

src/components/services/HomeAssistant.vue Outdated Show resolved Hide resolved
src/components/services/HomeAssistant.vue Outdated Show resolved Hide resolved
@emilywotruba
Copy link
Contributor Author

Thank you for reviewing my request @bastienwirtz. Are your concerns addressed by my new commits?

Copy link
Owner

@bastienwirtz bastienwirtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the linting issue, everything looks good @emilywotruba, thanks 🙏

src/components/services/HomeAssistant.vue Outdated Show resolved Hide resolved
@bastienwirtz bastienwirtz merged commit 765a24e into bastienwirtz:main May 22, 2024
1 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants